Idea: introduce python to rework the way the checks are made #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello people from Neuvector. I have been using the Kubernetes CIS benchmarks checks and thought to rework them in Python, this can bring an easier time developing and maintaining the checks as we can use OOP to inherit customized checks from base ones.
Of course this is just an idea, I don't know how you intend to maintain this repository, but I want to give this a try and collect feedback. If you guys think it's a good idea and give me a green light, I will continue the refactoring of the 1.6.0 version.
In this PR there is a sample of how it could be done for the first two Control Plane checks.
In terms of dependencies, it shifts the need from cli packages such as
sed
andawk
to onlypython3
. The idea is to code without using external pip libraries.Thanks for your time :)